Initial implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
force-pushed
the
myron/initial-implementation
branch
2 times, most recently
from
b59e21a
to
a62dda5
Compare
myronmarston
force-pushed
the
myron/initial-implementation
branch
from
a62dda5
to
c1e93b9
Compare
| # If you run "mix test --cover", coverage assets end up here. | ||
| /cover | ||
|
|
||
| # The directory Mix downloads your dependencies sources to. |
|
Thanks, @jmodjeska -- I addressed all your feedback. |
|
|
||
| ## Installation | ||
|
|
||
| If [available in Hex](https://hex.pm/docs/publish), the package can be installed as: |
There was a problem hiding this comment.
This conditional language feels pretty awkward; I assume we'll publish to hex right when we open-source. Given that, I think we can exclude the conditional entirely and assume the package has already been published?
There was a problem hiding this comment.
This is the text that mix new generates. I was planning to update it once I publish.
|
LGTM! |
|
Looks clean for open sourcing to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to open source our
ProcessTreeDictionaryimplementation. This PR is a start of that process. For now, this repo is private until I get permission to make it public.