Permalink
Browse files

CRITICAL bug fix

Turns out, didn't have unit testing in place to ensure that locks are also updated
when jobs are heartbeated. As a result, jobs would fallaciously report their
heartbeats as being in the future when in reality their locks could be close to
expiring.
  • Loading branch information...
1 parent 867a503 commit 9cc4ea3c59181acd0ab2e01b2c23e921f037c496 Dan Lecocq committed Apr 25, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 heartbeat.lua
View
@@ -45,6 +45,6 @@ else
-- And now we should just update the locks
local queue = redis.call('hget', 'ql:j:' .. jid, 'queue')
- redis.call('zadd', 'ql:q:'.. queue, expires, jid)
+ redis.call('zadd', 'ql:q:'.. queue .. '-locks', expires, jid)
return expires
end

0 comments on commit 9cc4ea3

Please sign in to comment.