Undefined class constant errors are not logged to the Qless UI #74

Closed
myronmarston opened this Issue Jan 28, 2013 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

myronmarston commented Jan 28, 2013

In Qless::Worker#perform it has a rescue clause that calls job.klass.retryable_exception_classes, but if the job class constant is not defined, the job will fail without being rescued and logged. We should fix this.

Contributor

myronmarston commented Jan 28, 2013

Two ideas for solutions:

  • The bandaid solution: in Worker#retryable_exception_classes rescue undefined constant errors, and return a blank array.
  • The better solution: introduce per-job middleware, and change the retryable exception code to simply be a middleware rather than requiring logic in the worker itself.

myronmarston added a commit that referenced this issue Jan 31, 2013

Merge pull request #76 from seomoz/fix-74
Fix #74 using the "bandaid" solution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment