Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
add pagination to worker counts, preserves backwards compatibility #179
Conversation
wr0ngway
reviewed
Feb 27, 2014
| @@ -110,8 +110,8 @@ def initialize(client) | ||
| @client = client | ||
| end | ||
| - def counts | ||
| - JSON.parse(@client.call('workers')) | ||
| + def counts(offset = 0, count = 0) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
wr0ngway
Feb 27, 2014
Contributor
If backwards compatibility is not an issue, the count should default to 25 like the rest of the paginated methods. When both offset and count are 0, it gets the entire data set
wr0ngway
Feb 27, 2014
Contributor
If backwards compatibility is not an issue, the count should default to 25 like the rest of the paginated methods. When both offset and count are 0, it gets the entire data set
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
wr0ngway
Feb 27, 2014
Contributor
Note that there is single test failing (subscriber_spec#'can be stopped'), but it is unrelated to my changes - it fails without my changes after updating qless-core to head. I don't know enough to easily figure out why
|
Note that there is single test failing (subscriber_spec#'can be stopped'), but it is unrelated to my changes - it fails without my changes after updating qless-core to head. I don't know enough to easily figure out why |
wr0ngway commentedFeb 27, 2014
With any significant number of workers (we have 1300, soon to be 8K+), workers.counts becomes unwieldy, especially in the webui.
I tried to preserve backwards compatibility, so workers.counts without any args returns the entire set like it did before.
I also tried to match existing signatures that have pagination (e.g. offset, count as arguments).
Depends on seomoz/qless-core#42