Refactoring to add testing and the ability to import more paths #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Took a look over your changes in this commit - looks really nice. Starting using shovel recently, and there are a few tweaks I'd like to make. But it might be best to wait until this pull request is accepted, as some serious refactoring has taken place. (1) Does that make sense and (2) do you have a sense for when the merge will occur? Many thanks! |
| */shovel/* | ||
|
|
||
| .coverage |
dlecocq
pushed a commit
that referenced
this pull request
Jan 22, 2014
Refactoring to add testing and the ability to import more paths
|
+1 on moving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, to improve the behavior of folder-level tasks (like defined in
foo/__init__.py) and for global scripts in~/.shovel.pyand~/.shovel(#18)I have yet to check on
shovel-campfireandshovel-server, but I have a feeling that 1) these utilities aren't used very often and 2) should be moved into their own repos.