New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmtime() + s3_enabled + role discovery #4

Merged
merged 2 commits into from Sep 12, 2012

Conversation

Projects
None yet
2 participants
@phobos182
Contributor

phobos182 commented Sep 11, 2012

Added a few features to yum-s3-iam. Thanks for the code.

1: email.utils time is incorrect. It's using local timezone information from the host to get offsets to calculate gmtime(). If the local timezone is not UTC, you get 403's from S3. Removed email.utils, and added gmtime() from time.
2: s3_enabled=1 is an option in the yum repo file. This is direct from s3-yum, and allows mixing / matching of yum repos that are S3, or regular.
3: Added the ability for the system to discover it's role from the EC2 metadata. No need to specify a role as it is immutable from AMI launch time.

Thanks!

phobos182 added some commits Sep 11, 2012

Added a few features. s3_enabled=(0|1) so you can mix/match s3 repos …
…with non s3 repos.

Fixed email.utils time. Was using local timezone to calculate GMT offset from. Invalid date breaks requests unless timezone=UTC on host system. Replaced with time.gmtime()
@seporaitis

This comment has been minimized.

Show comment
Hide comment
@seporaitis

seporaitis Sep 12, 2012

Owner

Great stuff @phobos182 I am merging this.

Thanks!

Owner

seporaitis commented Sep 12, 2012

Great stuff @phobos182 I am merging this.

Thanks!

seporaitis added a commit that referenced this pull request Sep 12, 2012

Merge pull request #4 from phobos182/master
gmtime() + s3_enabled + role discovery

@seporaitis seporaitis merged commit 2f4ea5d into seporaitis:master Sep 12, 2012

@ghost ghost assigned seporaitis Sep 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment