[INFRA] Merge App-Template and add codecoverage #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flags. Changes: * Link against google test targets with "d" suffix in the target name when building in debug mode. * Use the same cmake flags to configure googletest as used for the project These changes make sure that the google test target is configured and built with the same flags as given to the top level cmake file. This avoids some incompatibilities, e.g. that the debug targets are not found by the test binaries, when build in debug mode.
[INFRA] Allows to configure googletest with the same top-level cmake flags.
[INFRA] Use GitHub CI.
[INFRA] Update GitHub CI
[FIX] use unique test fixtures
[MISC] Make SeqAn3 test includes available in api test
* [INFRA] cmake: use seqan3 googletest A better attempt at fixing seqan/app-template#37 * test * test2 * like this? Co-authored-by: Enrico Seiler <enrico.seiler@hotmail.de>
[FIX] using old homebrew version
Co-authored-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de> Co-authored-by: David Heller <heller_d@molgen.mpg.de>
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
[TEST] Adds the codecoverage test
[INFRA] Update CI
Irallia
force-pushed
the
INFRA/merge_apptemplate
branch
from
af132cf
to
fe2c213
Compare
Irallia
force-pushed
the
INFRA/merge_apptemplate
branch
from
fe2c213
to
91bee9f
Compare
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Irallia
force-pushed
the
INFRA/merge_apptemplate
branch
2 times, most recently
from
9c17d1a
to
5ac6403
Compare
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=========================================
Coverage ? 85.45%
=========================================
Files ? 4
Lines ? 110
Branches ? 0
=========================================
Hits ? 94
Misses ? 16
Partials ? 0 Continue to review full report at Codecov.
|
Irallia
changed the title
Irallia
commented
May 10, 2021
Comment on lines
+34
to
+37
| # - name: "gcc11" | ||
| # cxx: "g++-11" | ||
| # cc: "gcc-11" | ||
| # build_type: Release |
There was a problem hiding this comment.
for gcc11 on linux the tests didn't run through...
[ RUN ] iGenVar_cli_test.test_unknown_argument
../../../src/test/cli/iGenVar_cli_test.cpp:308: Failure
Expected equality of these values:
result.err
Error: ch is: "[Error] You have chosen an invalid input value: 9. Please use one of: [read_depth,read_pairs,split_read,3,1,2,cigar_string,0]\n"
expected_err
Error: ch is: "[Error] You have chosen an invalid input value: 9. Please use one of: [read_depth,3,read_pairs,2,split_read,1,cigar_string,0]\n"
[ FAILED ] iGenVar_cli_test.test_unknown_argument (4 ms)
There was a problem hiding this comment.
The enumeration_names is a map, so the order of keys is not fixed and may differ for each compiler/os/etc.
You could, in a follow up PR, for example change the test to tokenise (split) the [read_depth,...,...,..,] part and check if everything is there. Something like splitting at ,, putting the strings into a set and then comparing two sets would work.
Or just have a fixed order in the help/error message, which would require changes in seqan3
eseiler
approved these changes
May 10, 2021
eseiler
reviewed
May 10, 2021
| @@ -8,16 +8,16 @@ if (${DOXYGEN_FOUND}) | |||
|
|
|||
| # Configure doxygen options. | |||
| set (APP_TEMPLATE_DOXYFILE_IN ${CMAKE_SOURCE_DIR}/doc/doxygen_cfg) | |||
| set (APP_TEMPLATE_DOXYGEN_OUTPUT_DIR "${PROJECT_BINARY_DIR}/doc") | |||
| set (IGENVAR_DOXYGEN_OUTPUT_DIR "${PROJECT_BINARY_DIR}/doc") | |||
There was a problem hiding this comment.
still APP_TEMPLATE_DOXYGEN_OUTPUT_DIR in the doxyfile.
13 tasks
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Irallia
force-pushed
the
INFRA/merge_apptemplate
branch
from
5ac6403
to
3761e1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #116 (add codecoverage)
Resolves #112 (write more tests, until codecove is higher than 85%)
And with this it resolves #30 (EPIC: Write API & CLI tests for all functions)
This PR merges the App-Template into iGenVar again. Thus we get the latest updates of the app-template including codecoverage.