Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] move seqan3::views::convert to seqan3/utility/views/ #2524

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Apr 19, 2021

@vercel
Copy link

vercel bot commented Apr 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/FWoRuicNg39zFTViWbcLGME5T1Ch
✅ Preview: https://seqan3-git-fork-eseiler-misc-deprecateviewsconvert-seqan.vercel.app

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #2524 (0a32790) into master (c468426) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2524   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files         269      269           
  Lines       10521    10521           
=======================================
  Hits        10334    10334           
  Misses        187      187           
Impacted Files Coverage Δ
...ignment/matrix/detail/aligned_sequence_builder.hpp 100.00% <ø> (ø)
include/seqan3/io/sequence_file/output.hpp 100.00% <ø> (ø)
include/seqan3/io/structure_file/output.hpp 100.00% <ø> (ø)
...de/seqan3/range/container/bitcompressed_vector.hpp 100.00% <ø> (ø)
include/seqan3/search/search.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/nucleotide/dna16sam.hpp 100.00% <100.00%> (ø)
include/seqan3/io/sam_file/format_bam.hpp 96.21% <100.00%> (ø)
include/seqan3/utility/views/convert.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b8c5d...0a32790. Read the comment docs.

@eseiler eseiler requested review from a team and MitraDarja and removed request for a team April 19, 2021 17:51
@MitraDarja MitraDarja requested review from a team and marehr and removed request for a team April 20, 2021 08:23
Copy link
Member

@marehr marehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small things, thank you so much :)

doc/cookbook/alphabet_conversion.cpp Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
test/snippet/alphabet/composite/semialphabet_any.cpp Outdated Show resolved Hide resolved
test/snippet/alphabet/composite/semialphabet_any.cpp Outdated Show resolved Hide resolved
auto v4 = qcvec | seqan3::views::to_rank | seqan3::views::convert<unsigned>;
seqan3::debug_stream << v4 << '\n'; // [1,28,22,15,30,16,121,67,92]
auto v4 = qcvec | seqan3::views::to_rank;
seqan3::debug_stream << v4 << '\n'; // [42,7,89,129,91,4,72,142,23]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups? this was wrong?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

Copy link
Member

@marehr marehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@marehr marehr merged commit a06e54c into seqan:master Apr 20, 2021
@marehr marehr changed the title [MISC] deprecate seqan3::views::convert [MISC] move seqan3::views::convert to seqan3/utility/views/ Apr 21, 2021
@eseiler eseiler deleted the misc/deprecate_views_convert branch May 14, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate seqan3::views::convert Add sequence conversion to cookbook
3 participants