-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] move seqan3::views::convert to seqan3/utility/views/ #2524
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/FWoRuicNg39zFTViWbcLGME5T1Ch |
ac419f6
to
52ce57c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2524 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 269 269
Lines 10521 10521
=======================================
Hits 10334 10334
Misses 187 187
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small things, thank you so much :)
auto v4 = qcvec | seqan3::views::to_rank | seqan3::views::convert<unsigned>; | ||
seqan3::debug_stream << v4 << '\n'; // [1,28,22,15,30,16,121,67,92] | ||
auto v4 = qcvec | seqan3::views::to_rank; | ||
seqan3::debug_stream << v4 << '\n'; // [42,7,89,129,91,4,72,142,23] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ups? this was wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup
6382a4c
to
0a32790
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!!
Resolves seqan/product_backlog#324
Resolves seqan/product_backlog#215