[FIX] relax seqan3::views::kmer_hash requirements to be C++20 compatible #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marehr
requested review from
a team and
MitraDarja
and removed request for
a team
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/AU8mJCWbn8sogDxDjbKSDNe2Su61 |
7 tasks
```
/seqan3/test/unit/search/views/minimiser_test.cpp:78:83: error: use of deleted function ‘seqan3::detail::kmer_hash_view<urng_t>::kmer_hash_view() [with urng_t = std::ranges::ref_view<std::vector<seqan3::dna4> >]’
78 | using test_range_t = decltype(seqan3::detail::minimiser_view{kmer_hash_view_t{}, reverse_kmer_hash_view_t{}, 5});
| ^
```
MitraDarja
approved these changes
Oct 6, 2021
MitraDarja
requested review from
a team and
smehringer
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #2843 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 277 277
Lines 10963 10963
=======================================
Hits 10785 10785
Misses 178 178
Continue to review full report at Codecov.
|
smehringer
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seqan/product_backlog#403