New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] binning_directory #920

Merged

smehringer merged 5 commits into seqan:master from eseiler:feature/binning_directory

Feb 25, 2020

Member

eseiler commented Apr 16, 2019 •

edited

Loading

Blocked by ~~#933~~

Resolves #1562

TODO:

eseiler requested a review from smehringer

April 16, 2019 14:49

codecov bot commented Apr 16, 2019 •

edited

Loading

Codecov Report

Merging #920 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
+ Coverage   97.63%   97.65%   +0.02%     
==========================================
  Files         235      236       +1     
  Lines        8908     9005      +97     
==========================================
+ Hits         8697     8794      +97     
  Misses        211      211

Impacted Files	Coverage Δ
...n3/search/dream_index/interleaved_bloom_filter.hpp	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c82a0...4e9b2e4. Read the comment docs.

eseiler force-pushed the feature/binning_directory branch 2 times, most recently from f4c55c7 to b77dd42 Compare

April 23, 2019 12:29

eseiler force-pushed the feature/binning_directory branch 2 times, most recently from 66d6f7d to 59fc34d Compare

May 1, 2019 10:06

eseiler force-pushed the feature/binning_directory branch from 59fc34d to 9509b92 Compare

May 7, 2019 13:41

eseiler force-pushed the feature/binning_directory branch 3 times, most recently from cb2762c to bbb625b Compare

May 17, 2019 16:24

smehringer requested changes

View reviewed changes

include/seqan3/search/dream_index/binning_directory.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/binning_directory.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/binning_directory.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/binning_directory.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/binning_directory.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/detail/bitvector.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/detail/bitvector.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/detail/bitvector.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/detail/bitvector.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/detail/bitvector.hpp Outdated Show resolved Hide resolved

eseiler force-pushed the feature/binning_directory branch 2 times, most recently from 004bc29 to 94885ed Compare

June 20, 2019 13:30

eseiler requested a review from smehringer

June 20, 2019 13:31

eseiler force-pushed the feature/binning_directory branch from 94885ed to 3c92278 Compare

June 21, 2019 05:20

smehringer requested changes

View reviewed changes

Member

smehringer left a comment

Just some stuff I came across when scanning the code to evaluate if mitra can use it already.

include/seqan3/search/dream_index/binning_directory.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/detail/binning_directory_base.hpp Outdated Show resolved Hide resolved

test/unit/search/dream_index/binning_directory_test.cpp Outdated Show resolved Hide resolved

eseiler force-pushed the feature/binning_directory branch from 3c92278 to 20fe7e5 Compare

August 30, 2019 11:25

marehr requested a review from smehringer

September 30, 2019 15:01

eseiler removed the request for review from smehringer

September 30, 2019 15:14

smehringer requested changes

View reviewed changes

include/seqan3/search/dream_index/binning_directory.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/binning_directory.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/binning_directory.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/binning_directory.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/binning_directory.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/detail/binning_directory_base.hpp Outdated Show resolved Hide resolved

test/performance/search/dream_index/binning_directory_benchmark.cpp Outdated Show resolved Hide resolved

test/performance/search/dream_index/binning_directory_benchmark.cpp Outdated Show resolved Hide resolved

test/performance/search/dream_index/binning_directory_benchmark.cpp Outdated Show resolved Hide resolved

test/unit/search/dream_index/binning_directory_test.cpp Outdated Show resolved Hide resolved

smehringer reviewed

View reviewed changes

include/seqan3/search/dream_index/all.hpp Outdated Show resolved Hide resolved

eseiler force-pushed the feature/binning_directory branch from 20fe7e5 to ab210b7 Compare

January 24, 2020 06:53

smehringer requested a review from MitraDarja

January 27, 2020 06:51

MitraDarja requested changes

View reviewed changes

Contributor

MitraDarja left a comment

Some minor things

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

test/performance/search/dream_index/interleaved_bloom_filter_benchmark.cpp Outdated Show resolved Hide resolved

test/snippet/search/dream_index/interleaved_bloom_filter_constructor_compressed.cpp Show resolved Hide resolved

test/snippet/search/dream_index/interleaved_bloom_filter_get.cpp Outdated Show resolved Hide resolved

test/unit/search/dream_index/interleaved_bloom_filter_test.cpp Show resolved Hide resolved

MitraDarja reviewed

View reviewed changes

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Show resolved Hide resolved

eseiler force-pushed the feature/binning_directory branch from 04fb9c4 to ba3680e Compare

February 11, 2020 12:20

eseiler commented

View reviewed changes

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Show resolved Hide resolved

eseiler requested review from MitraDarja and smehringer

February 11, 2020 17:17

MitraDarja requested changes

View reviewed changes

Contributor

MitraDarja left a comment

Looks goods, just some small things. :)

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

eseiler requested a review from MitraDarja

February 13, 2020 13:03

MitraDarja approved these changes

View reviewed changes

Contributor

MitraDarja left a comment

Looks good to me. :)

smehringer requested changes

View reviewed changes

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

eseiler force-pushed the feature/binning_directory branch from 9156803 to 58223ca Compare

February 19, 2020 09:13

eseiler requested a review from smehringer

February 19, 2020 09:31

eseiler commented

View reviewed changes

test/include/seqan3/test/performance/sequence_generator.hpp Outdated Show resolved Hide resolved

smehringer requested changes

View reviewed changes

Member

smehringer left a comment

only tiny 💅 and then we can check the hash function once I have some tests on the uniformity

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

eseiler requested a review from smehringer

February 20, 2020 12:24

eseiler mentioned this pull request

[TEST] Index Benchmark #960

Merged

eseiler added a commit to Clemapfel/seqan3 that referenced this pull request


          Blocked by seqan#920

c896306

eseiler added 2 commits

February 25, 2020 09:32


          [FEATURE] Interleaved Bloom Filter

72c716a


          [MISC] Optimize hashing

d3c9167

eseiler force-pushed the feature/binning_directory branch from 339c607 to d3c9167 Compare

February 25, 2020 08:33

smehringer requested changes

View reviewed changes

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

include/seqan3/search/dream_index/interleaved_bloom_filter.hpp Outdated Show resolved Hide resolved

eseiler added 2 commits

February 25, 2020 11:36


          Review

ec00672


          Docs

ff0a58c

eseiler requested a review from smehringer

February 25, 2020 11:04


          Fixes

4e9b2e4

smehringer approved these changes

View reviewed changes

smehringer merged commit 3b6738d into seqan:master

eseiler deleted the feature/binning_directory branch

May 3, 2020 21:10

rrahn mentioned this pull request

3.0.2 Release #2001

Closed

27 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet