fix(model): fix count with grouping typing (#13884)

* fix(model): fix count with grouping typing Fixes #13871 * test: update Model.count(group) typing test Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
sequelize · Jan 4, 2022 · 49beb29 · 49beb29
1 parent b315ce8
commit 49beb29
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/types/lib/model.d.ts b/types/lib/model.d.ts
@@ -1907,7 +1907,7 @@ export abstract class Model<TModelAttributes extends {} = any, TCreationAttribut
   public static count<M extends Model>(
     this: ModelStatic<M>,
     options: CountWithOptions<M['_attributes']>
-  ): Promise<{ [key: string]: number }>;
+  ): Promise<Array<{ [groupKey: string]: unknown, count: number }>>;
 
   /**
    * Count the number of records matching the provided where clause.

diff --git a/types/test/count.ts b/types/test/count.ts
@@ -4,7 +4,8 @@ import { Model, Op } from 'sequelize';
 class MyModel extends Model {}
 
 expectTypeOf(MyModel.count()).toEqualTypeOf<Promise<number>>();
-expectTypeOf(MyModel.count({ group: 'tag' })).toEqualTypeOf<Promise<{ [key: string]: number }>>();
+expectTypeOf(MyModel.count({ group: 'tag' }))
+  .toEqualTypeOf<Promise<Array<{ [groupKey: string]: unknown, count: number }>>>();
 expectTypeOf(MyModel.count({ col: 'tag', distinct: true })).toEqualTypeOf<Promise<number>>();
 expectTypeOf(MyModel.count({
   where: {