Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on isolation levels conflicts in different parts #10111

Closed
linpekka opened this issue Nov 1, 2018 · 1 comment
Closed

Documentation on isolation levels conflicts in different parts #10111

linpekka opened this issue Nov 1, 2018 · 1 comment
Labels
type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.

Comments

@linpekka
Copy link

linpekka commented Nov 1, 2018

What are you doing?

I want to globally use REPEATABLE_READ as transaction isolation level unless overridden. This was the behaviour for in sequelize 3 and I missed that this was mentioned in the migration docs, (it is, i saw it today).

In one part of the docs
http://docs.sequelizejs.com/manual/tutorial/transactions.html#isolation-levels
I find the following

By default, sequelize uses the isolation level of the database. If you want to use a different isolation level, pass in the desired level as the first argument:

And in another part
http://docs.sequelizejs.com/class/lib/transaction.js~Transaction.html
I find the following

Isolations levels can be set per-transaction by passing options.isolationLevel to sequelize.transaction. Default to REPEATABLE_READ but you can override the default isolation level by passing options.isolationLevel in new Sequelize.

What do you expect to happen?

I would like the second part to be update to match the system, and I would also like to have a way to globally override the default isolation level, to easily get back to the v3 behavior. Manually adding an override on every transaction seems like a pain.

@linpekka
Copy link
Author

linpekka commented Nov 1, 2018

found the option to override it when initializing, so just the documentation issue outstanding

@sushantdhiman sushantdhiman added the type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. label Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.
Projects
None yet
Development

No branches or pull requests

2 participants