fix: decode encoded value from urlParts.pathname for database option

[fzn0x]

Pull Request Checklist

Please make sure to review and check all of these items:

• Have you added new tests to prevent regressions?
• Does yarn test or yarn test-DIALECT pass with this change (including linting)?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Did you update the typescript typings accordingly (if applicable)?
• Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
• Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Close #14962

options.database returning bad value for database connection, this affected to all database except the options.dialect with postgres as the value.

sequelize/src/utils/url.ts

Line 71 in a68b439

if (options.dialect === 'postgres') {

You can notice the strange thing by running this code with NodeJS:

import url from 'url';

const urlParts = url.parse("pg://wpx%20ss:wpx%20ss@21.77.77:4001/database ss", true);

const options = {}

// adding decodeURI solve the database issue.
options.database = decodeURI(urlParts.pathname.replace(/^\//, ''));
console.log(urlParts.auth);

// urlParts.auth already decode the encoded URI value by default
if (urlParts.auth) {
  const authParts = urlParts.auth.split(':');
  options.username = authParts[0];
  if (authParts.length > 1) {
    options.password = authParts.slice(1).join(':');
  }
}

console.log(options)

Todos

• Add decodeURI for handling urlParts.pathname value

[fzn0x]

Do you have any suggestion for the unit test? @WikiRik

Since the Utils does not include url functions on sequelize/core

sequelize/test/unit/utils/utils.test.ts

Line 3 in a68b439

import { Utils } from '@sequelize/core';

We need to add a another PR that includes the url utility or all the other utilities too and release it to new v7 alpha version, you can take a part for this, or the alternative solution is I am to import the url utility directly.

[fzn0x]

Or skip the unit test also fine for me, since the decodeURIComponent itself is the function coming from nodejs core, which is the part of the built-in we probably no doubt to use.

[WikiRik]

Do you have any suggestion for the unit test? @WikiRik

I was thinking we could add unit tests for parseConnectionString to check if everything is parsing correctly. I do think that testing decodeURIComponent separately is not needed.

[fzn0x]

Hi @WikiRik did you have any inputs left on this PR or we good to go?

[WikiRik]

Looks good to me, but I'll wait with approval until further comment by @wkrasnicki-vizlib

[wkrasnicki-vizlib]

Yes, this solves the issue. Thank you guys

[fzn0x]

Glad it helps, thank you guys!

[github-actions]

🎉 This PR is included in version 7.0.0-alpha.17 🎉

The release is available on:

• npm package (@release-v7 dist-tag)
• GitHub release

Your semantic-release bot 📦🚀