New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DataTypes do not allow postgres character varying(n)[] #3106

Closed
BridgeAR opened this Issue Feb 11, 2015 · 4 comments

Comments

2 participants
@BridgeAR
Contributor

BridgeAR commented Feb 11, 2015

A few days ago it was still possible to use DataTypes.ARRAY(DataTypes.STRING(n)). This is not possible with the refactored DataTypes and throws the following error:

/node_modules/sequelize/lib/sequelize.js:1175
if (type instanceof DataTypes.ARRAY && dialectTypes[type.type.key]) {
^
TypeError: Cannot read property 'key' of undefined

It's not really a big issue to change that to DataTypes.ARRAY(DataTypes.STRING) but it would be nice to have the old functionality.

@mickhansen mickhansen added the bug label Feb 11, 2015

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Feb 11, 2015

Ah, that's a regression i'll get fixed.
What's the expected SQL for a VARCHAR ARRAY with length?

@BridgeAR

This comment has been minimized.

Contributor

BridgeAR commented Feb 11, 2015

"columnName" VARCHAR(n)[]

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Feb 11, 2015

@BridgeAR roger

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Feb 12, 2015

Fixed in sequelize@2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment