Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model.attributes should be Model.rawAttributes #5320

Closed
mickhansen opened this issue Jan 28, 2016 · 4 comments
Closed

Model.attributes should be Model.rawAttributes #5320

mickhansen opened this issue Jan 28, 2016 · 4 comments
Labels
breaking change For issues and PRs. Changes that break compatibility and require a major version increment.
Milestone
v5

Comments

@mickhansen
Copy link
Contributor

No description provided.

@mickhansen mickhansen added this to the 4.0 milestone Jan 28, 2016
@mickhansen mickhansen added the breaking change For issues and PRs. Changes that break compatibility and require a major version increment. label Jan 28, 2016
@sushantdhiman sushantdhiman modified the milestones: 5.0, 4.0 Jun 8, 2017
@stale stale bot added the stale label Aug 12, 2017
@stale
Copy link

stale bot commented Aug 12, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, just leave a comment 🙂

@stale stale bot closed this as completed Aug 19, 2017
@sushantdhiman sushantdhiman mentioned this issue Aug 19, 2017
Merged
@sushantdhiman sushantdhiman reopened this Oct 4, 2017
@stale stale bot removed the stale label Oct 4, 2017
@sushantdhiman
Copy link
Contributor

Fixed by #8160

Need to removed Model.attributes in v5

@superlbr
Copy link

Since attributes were loaded when model init, what if I changed attributes defined in models and database later and keep the original js program running .I got an error because the attributes still unchanged in memory. Disappointed that I didn't take a picture...

@sushantdhiman
Copy link
Contributor

This change is now included in v5 branch https://github.com/sequelize/sequelize/tree/v5

@sushantdhiman sushantdhiman mentioned this issue Mar 21, 2018
Merged
@Alamantus Alamantus mentioned this issue Jan 30, 2020
Merged
@rubicola rubicola mentioned this issue Jun 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change For issues and PRs. Changes that break compatibility and require a major version increment.
Projects
None yet
Milestone
v5
Development

No branches or pull requests
3 participants
@mickhansen @superlbr @sushantdhiman