underscore / camelcase option should control all fields and table name generation

[alexey2baranov]

It would be great if sequelize will generate PostgreSQL DDL with lower_case_underscored table name and column names. By now underscore option manage foreign keys and create_at, modifed_at fields only.

In short

CREATE TABLE IF NOT EXISTS "Male" ("CamelCase" VARCHAR(255), "created_at" TIMESTAMP WITH TIME ZONE NOT NULL, "updated_at" TIMESTAMP WITH TIME ZONE NOT NULL);

should become

CREATE TABLE IF NOT EXISTS male (camel_case VARCHAR(255), "created_at" TIMESTAMP WITH TIME ZONE NOT NULL, "updated_at" TIMESTAMP WITH TIME ZONE NOT NULL);

my global config is

{
    "username": "",
    "password": "",
    "database": "",
    "host": "127.0.0.1",
    "dialect": "postgres",
    "define":{
      "paranoid":false,
      "timestamps":true,
      "freezeTableName": true,
      "underscored": true
    }
}

[sushantdhiman]

Sounds like a reasonable feature to me, @janmeier ?

[janmeier]

I don't think this is needed - If users want underscored names, they can simply define them as such, or use the field option.

The underscored option is for controlling auto-generated column names, but when a user tells us about the column fooBar, we call it fooBar ;)

This can easily be solved with a beforeDefine hook

[sushantdhiman]

Correct, but there is lots of work involved with that 😆 , I would prefer one single option based control.

If anyone can share their experiences from other ORMs like ActiveRecord (Rails) or Eloquent (Laravel / PHP), that will be really helpful to make this decision.

[felixfbecker]

I also prefer underscored columns and tables and camelCase attributes and PascalCase model names. I think the ORM should allow to map this easily.

[maxsummers]

It took me a long time to figure out why underscored option didn't convert my camelCase column names to under_scored ones.

I would also prefer to declare my columns as camelCased ones to be automatically converted later to underscored ones in SQL.

[elvisgs]

+1

[quocvu]

I also agree w/ @alexey2baranov. I know we use of the field option, but that makes the model more verbose. Typically, when we name a field fooBar, it is to keep it consistent w/ the rest of the javascript code and not that we really want fooBar as a column name.

The current behavior is not desirable. Who would want mixed column naming scheme in their tables?

At the minimum, the documentation should be fixed. It doesn't say underscored only applies to auto-generated fields.

Converts all camelCased columns to underscored if true. Will not affect timestamp fields named explicitly by model options and will not affect fields with explicitly set field option

[pgollangi]

+1

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, just leave a comment 🙂