Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node 6 and up #9015

Closed
sushantdhiman opened this issue Feb 8, 2018 · 12 comments
Closed

Support Node 6 and up #9015

sushantdhiman opened this issue Feb 8, 2018 · 12 comments
Milestone

Comments

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Feb 8, 2018

https://github.com/nodejs/Release#release-schedule

Node 4 Maintenance LTS is ending soon (on 2018-04-30) and all cloud function providers AWS, Google, Azure and IBM supports Node v6

@sushantdhiman sushantdhiman modified the milestones: v5, 5.0 Feb 8, 2018
@sushantdhiman
Copy link
Contributor Author

@sushantdhiman sushantdhiman commented Mar 21, 2018

Included in v5 branch

@SimonSchick
Copy link
Member

@SimonSchick SimonSchick commented Apr 30, 2018

Would it be possible to skip right to v8, seeing that v8 and v10 are both LTS?

@sushantdhiman
Copy link
Contributor Author

@sushantdhiman sushantdhiman commented Apr 30, 2018

No

@SimonSchick
Copy link
Member

@SimonSchick SimonSchick commented Apr 30, 2018

No.

Is there any particular reason why?

@dijonkitchen
Copy link
Contributor

@dijonkitchen dijonkitchen commented May 2, 2018

Probably because version 6.x is supported as an LTS until 2019.

@sushantdhiman
Copy link
Contributor Author

@sushantdhiman sushantdhiman commented May 2, 2018

Main reason is already stated

all cloud function providers AWS, Google, Azure and IBM supports Node v6

@SimonSchick
Copy link
Member

@SimonSchick SimonSchick commented Dec 18, 2018

@sushantdhiman all cloud providers you named now fully support v8.
v6 LTS ends in ~4 months, I think it would be sensible to release v5 targeting v8 instead.

@sushantdhiman
Copy link
Contributor Author

@sushantdhiman sushantdhiman commented Dec 18, 2018

I agree @SimonSchick , I planned v5 to be a quick iteration but release has been stretched further. Now it make sense to bump directly to Node 8 at least.

cls is a blocker atm, will have to look into implementing https://github.com/Jeff-Lewis/cls-hooked

@SimonSchick
Copy link
Member

@SimonSchick SimonSchick commented Dec 18, 2018

Can you elaborate what it is blocking exactly?

@sushantdhiman
Copy link
Contributor Author

@sushantdhiman sushantdhiman commented Dec 18, 2018

@SimonSchick first we have to migrate our codebase to use cls-hooked, probably locking Node to 8.10 or above (no real issue with that), then we have to write tests for functionality using cls with native async await especially important for transactions.

Migration to cls-hooked is required as continuation-local-storage itself is using AsyncListener which wont work for Node 8 or up

This is mostly some (easy) modernization work with tedious rewrite (of tests) overall but real blocker if we want to support cls in Node 8

@SimonSchick
Copy link
Member

@SimonSchick SimonSchick commented Dec 19, 2018

I assume you are going to do this?
I'm not exactly familiar with the cls stuff since I've never used it.

@ayushnigamsworld
Copy link

@ayushnigamsworld ayushnigamsworld commented May 21, 2019

@SimonSchick first we have to migrate our codebase to use cls-hooked, probably locking Node to 8.10 or above (no real issue with that), then we have to write tests for functionality using cls with native async await especially important for transactions.

Migration to cls-hooked is required as continuation-local-storage itself is using AsyncListener which wont work for Node 8 or up

This is mostly some (easy) modernization work with tedious rewrite (of tests) overall but real blocker if we want to support cls in Node 8

Yes I think that is utterly needed. We are using Node 8, with async-await waterfall, cls simply fails. Then we used cls-hooked with Sequelize managed transactions and till now it's been working like a beauty for past 6 months. Moving to production with cls-hooked now. Anyone differ, do comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants