Suggestion: Remove all aliases in v5

[SimonSchick]

Not sure if I'm too late here but over the years Sequelize has create many many aliases functions. I think it would be a good idea to remove the aliases with the next major release.

• find vs. findOne
• findById vs. findByPrimary
• afterBulkDestroy vs afterBulkDelete
• addHook v. hook
• VIRTUAL vs NONE

Edit: Formatting

[sushantdhiman]

I have edited your post for better readability.

Good idea overall, we need to deprecate duplicate cases first, then remove them from master. This change should be easy to implement in small PRs

[SimonSchick]

@sunshinewyin the ones Iisted where just examples, there are quite a few more.

[SimonSchick]

@sushantdhiman I'll see if I can do that.

[madmoizo]

As requested by @sushantdhiman

Final

Remove	Keep
insertOrUpdate	upsert	✔️
findById, findByPrimary	findByPk	✔️
find	findOne	✔️
findAndCount	findAndCountAll	✔️
findOrInitialize	findOrBuild	✔️
beforeConnection	beforeConnect	✔️
[after,before]BulkDelete	[after,before]BulkDestroy	✔️
[after,before]Delete	[after,before]Destroy	✔️
hook	addHook	✔️
updateAttributes	update	✔️
DOUBLE PRECISION	DOUBLE	❌
NUMERIC	DECIMAL	❌
NONE	VIRTUAL	✔️
asIs	literal	✔️
Sequelize.condition	Sequelize.where	✔️
Sequelize.prototype.Utils	Sequelize.Utils	✔️
Sequelize.prototype.Promise	Sequelize.Promise	✔️
Sequelize.prototype.TableHints	Sequelize.TableHints	✔️
Sequelize.prototype.Op	Sequelize.Op	✔️
Sequelize.prototype.Transaction	Sequelize.Transaction	✔️
Sequelize.prototype.Model	Sequelize.Model	✔️
Sequelize.prototype.Deferrable	Sequelize.Deferrable	✔️
Sequelize.prototype.Error	Sequelize.Error	✔️
Sequelize.prototype[error]	Sequelize[error]	✔️

Question

Should we add deprecation message or just add the migration table in the changelog ?

[sushantdhiman]

Thanks @frlinw , A few changes

1. Keep both hasHooks/hasHook.
2. upsert is well known name so we can keep this
3. findByPk suggestion accepted

Should we add deprecation message or just add the migration table in the changelog ?

I can take care of deprecating them from v4 once these changes land to master

[SimonSchick]

Yea sorry, been super busy, cudos to @frlinw for taking over.

[madmoizo]

I started to work on it. I'm doing some reorg for imports (require) in test files because it's a mess, will make a PR after that.

[madmoizo]

beforeConnection added to the list, it's not used internally and it's the last hook alias

[sushantdhiman]

Implemented in #9933

[SimonSchick]

Hey, what about all the prototype aliases eg.

Sequelize.prototype.fn = Sequelize.fn;
Sequelize.prototype.col = Sequelize.col;
Sequelize.prototype.cast = Sequelize.cast;
Sequelize.prototype.literal = Sequelize.literal;
Sequelize.prototype.and = Sequelize.and;
Sequelize.prototype.or = Sequelize.or;
Sequelize.prototype.json = Sequelize.json;
Sequelize.prototype.where = Sequelize.where;
Sequelize.prototype.validate = Sequelize.prototype.authenticate;

and more?

[sushantdhiman]

They are ok for now

[SimonSchick]

One more, what about the new DATATYPE() vs. DATETYPE() calls?

[sushantdhiman]

new DATETYPE() is sure more verbose than DATETYPE, I prefer short functional syntax in this case. Once I tried to convert datatypes to classes but stopped just because of this issue

[SimonSchick]

Another alias I came across is Transaction.LOCK vs. transactionInstance.LOCK, all other enums like that are static, why is that one available on the instance as well?

Also at the same time that section should be optimized, accessing enums shouldn't invoke object creation, we should just Object.freeze and assign it directly :)