Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sequelize.js #10002

Merged
merged 1 commit into from Oct 9, 2018
Merged

Update sequelize.js #10002

merged 1 commit into from Oct 9, 2018

Conversation

@nbouvrette
Copy link
Contributor

@nbouvrette nbouvrette commented Oct 6, 2018

Fix jsDoc to avoid IDE warning.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fix jsDoc to avoid IDE warning.
@codecov
Copy link

@codecov codecov bot commented Oct 6, 2018

Codecov Report

Merging #10002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10002   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files          63       63           
  Lines        9400     9400           
=======================================
  Hits         9061     9061           
  Misses        339      339
Impacted Files Coverage Δ
lib/sequelize.js 96.58% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f58b82...65fd8d4. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 8ac97ef into sequelize:master Oct 9, 2018
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 9f58b82...65fd8d4
Details
codecov/project 96.39% remains the same compared to 9f58b82
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 9, 2018

Thanks @nbouvrette

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants