Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(syntax): correct parentheses around union (#9813) #10003

Merged
merged 1 commit into from Oct 15, 2018

Conversation

@tsasaki609
Copy link
Contributor

@tsasaki609 tsasaki609 commented Oct 7, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

fix #9813

I wrapped a subquery to union.
Although it is a little tricky, no error occurs with this.

@tsasaki609 tsasaki609 force-pushed the tsasaki609:fix-union-syntax branch from 62ae49b to e27c50f Oct 7, 2018
@codecov
Copy link

@codecov codecov bot commented Oct 7, 2018

Codecov Report

Merging #10003 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10003   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files          63       63           
  Lines        9382     9382           
=======================================
  Hits         9043     9043           
  Misses        339      339
Impacted Files Coverage Δ
lib/dialects/abstract/query-generator.js 97.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd07ef...a6c1f01. Read the comment docs.

@tsasaki609 tsasaki609 force-pushed the tsasaki609:fix-union-syntax branch 2 times, most recently from b32abdc to aadbe0d Oct 11, 2018
@tsasaki609
Copy link
Contributor Author

@tsasaki609 tsasaki609 commented Oct 11, 2018

How is it like this?

@tsasaki609 tsasaki609 force-pushed the tsasaki609:fix-union-syntax branch 4 times, most recently from a79b386 to 9e456d7 Oct 12, 2018
@tsasaki609 tsasaki609 force-pushed the tsasaki609:fix-union-syntax branch from 9e456d7 to a6c1f01 Oct 13, 2018
@sushantdhiman sushantdhiman merged commit 55e5734 into sequelize:master Oct 15, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 96.38%)
Details
codecov/project 96.38% (+0%) compared to fcd07ef
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 15, 2018

Thanks @tsasaki609

Not sure when you last pushed the change, I didn't get any notification for last commit

@internalfx
Copy link

@internalfx internalfx commented Oct 25, 2018

Is this in the latest release yet? I'm still seeing this bug.

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 26, 2018

@internalfx 5.0.0-beta.13

@internalfx
Copy link

@internalfx internalfx commented Oct 26, 2018

Any chance for a 4.x branch release?

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 27, 2018

@internalfx cherry pick this commit and send a PR targeting v4 branch

@tzellman
Copy link

@tzellman tzellman commented Nov 4, 2018

Thanks @sushantdhiman! PR #10121 targets the v4 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants