fix(syntax): correct parentheses around union (#9813)#10003
Merged
sushantdhiman merged 1 commit intosequelize:masterfrom Oct 15, 2018
Merged
fix(syntax): correct parentheses around union (#9813)#10003sushantdhiman merged 1 commit intosequelize:masterfrom
sushantdhiman merged 1 commit intosequelize:masterfrom
Conversation
tsasaki609
force-pushed
the
fix-union-syntax
branch
from
62ae49b to
e27c50f
Compare
Codecov Report
@@ Coverage Diff @@
## master #10003 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 63 63
Lines 9382 9382
=======================================
Hits 9043 9043
Misses 339 339
Continue to review full report at Codecov.
|
tsasaki609
force-pushed
the
fix-union-syntax
branch
2 times, most recently
from
b32abdc to
aadbe0d
Compare
Contributor
Author
|
How is it like this? |
tsasaki609
force-pushed
the
fix-union-syntax
branch
4 times, most recently
from
a79b386 to
9e456d7
Compare
tsasaki609
force-pushed
the
fix-union-syntax
branch
from
9e456d7 to
a6c1f01
Compare
sushantdhiman
approved these changes
Oct 15, 2018
Contributor
|
Thanks @tsasaki609 Not sure when you last pushed the change, I didn't get any notification for last commit |
|
Is this in the latest release yet? I'm still seeing this bug. |
Contributor
|
@internalfx |
|
Any chance for a 4.x branch release? |
Contributor
|
@internalfx cherry pick this commit and send a PR targeting v4 branch |
|
Thanks @sushantdhiman! PR #10121 targets the |
sushantdhiman
pushed a commit
that referenced
this pull request
Nov 5, 2018
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
fix #9813
I wrapped a subquery to union.
Although it is a little tricky, no error occurs with this.