Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(query-interface): add inline 'bulkUpdate' docs #10005

Merged
merged 1 commit into from Oct 9, 2018

Conversation

@c-moss-talk
Copy link
Contributor

@c-moss-talk c-moss-talk commented Oct 8, 2018

Adds missing documentation on 'bulkUpdate' inline at query-interface.js. Addresses #8820

@sushantdhiman sushantdhiman merged commit 985c1d4 into sequelize:master Oct 9, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 9, 2018

Thanks @c-moss-talk

@jeanmarcprevost
Copy link

@jeanmarcprevost jeanmarcprevost commented Oct 19, 2018

I don't understand the documentation...
@param {Object} identifier A hash with conditions OR an ID as integer OR a string with conditions

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 19, 2018

where conditions

{
   name: "ABC",
   [Op.and]: [ .... ],
   ....
}
@c-moss-talk
Copy link
Contributor Author

@c-moss-talk c-moss-talk commented Oct 19, 2018

Yeah, that's a hash example, but actually I tried to use an ID as integer and it resulted in unexpected behavior. I want to look into it.

@jeanmarcprevost
Copy link

@jeanmarcprevost jeanmarcprevost commented Oct 23, 2018

Oh yes thank @sushantdhiman !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants