New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ssl option to uri for postgres #10025
Add ssl option to uri for postgres #10025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some tests in https://github.com/sequelize/sequelize/blob/master/test/unit/configuration.test.js#L57
Assert that dialectOptions
got new entries as specified in connection string
Codecov Report
@@ Coverage Diff @@
## master #10025 +/- ##
==========================================
+ Coverage 96.38% 96.38% +<.01%
==========================================
Files 63 63
Lines 9382 9386 +4
==========================================
+ Hits 9043 9047 +4
Misses 339 339
Continue to review full report at Codecov.
|
Sorry about the commit mistakes, I am newer to GitHub and still figuring out the nuances of pull requests. |
Thanks @justinkalland |
Is this going to be released on npm? Just came across this issue and tried changing |
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
Added support for the ssl option to the Postgres URI. For example:
The way I chose to support this was assigning any query parameters from the URI into
dialectOptions
. Then each dialectsConnectionManager.connect()
can use the parameters the same as if they were used in the constructor withoptions.dialectOptions
.Closes #10015
Related #9712, #6932, #5891