Add ssl option to uri for postgres #10025
Conversation
Please add some tests in https://github.com/sequelize/sequelize/blob/master/test/unit/configuration.test.js#L57 Assert that |
Codecov Report
@@ Coverage Diff @@
## master #10025 +/- ##
==========================================
+ Coverage 96.38% 96.38% +<.01%
==========================================
Files 63 63
Lines 9382 9386 +4
==========================================
+ Hits 9043 9047 +4
Misses 339 339
Continue to review full report at Codecov.
|
Sorry about the commit mistakes, I am newer to GitHub and still figuring out the nuances of pull requests. |
Thanks @justinkalland |
Is this going to be released on npm? Just came across this issue and tried changing |
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
Added support for the ssl option to the Postgres URI. For example:
The way I chose to support this was assigning any query parameters from the URI into
dialectOptions
. Then each dialectsConnectionManager.connect()
can use the parameters the same as if they were used in the constructor withoptions.dialectOptions
.Closes #10015
Related #9712, #6932, #5891