Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres): remove if not exists and cascade on create/drop db #10033

Merged
merged 4 commits into from Oct 16, 2018

Conversation

@ALiangLiang
Copy link
Contributor

@ALiangLiang ALiangLiang commented Oct 15, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Resolved #10030

Postgresql doesn't support CREATE DATABASE IF NOT EXISTS.... So remove words IF NOT EXISTS.

Add more options on postgresql CREATE DATABASE:

  • template
  • ctype

refs:

@ALiangLiang ALiangLiang changed the title fix(postgres): remove if not exists and cascade on create/drop db fix(postgres): remove if not exists and cascade on create/drop db Oct 15, 2018
@ALiangLiang ALiangLiang changed the title fix(postgres): remove if not exists and cascade on create/drop db fix(postgres): remove if not exists and cascade on create/drop db Oct 15, 2018
@codecov
Copy link

@codecov codecov bot commented Oct 15, 2018

Codecov Report

Merging #10033 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10033   +/-   ##
=======================================
  Coverage    96.3%    96.3%           
=======================================
  Files          63       63           
  Lines        9421     9421           
=======================================
  Hits         9073     9073           
  Misses        348      348
Impacted Files Coverage Δ
lib/dialects/mysql/query-generator.js 97.84% <ø> (ø) ⬆️
lib/query-interface.js 89.8% <0%> (ø) ⬆️
lib/dialects/postgres/query-generator.js 93.98% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e5734...0521f3f. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 198cb52 into sequelize:master Oct 16, 2018
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 50% of diff hit (target 96.3%)
Details
codecov/project 96.3% remains the same compared to 55e5734
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 16, 2018

Thanks @ALiangLiang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants