Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sqlite citext data-type #10036

Merged
merged 3 commits into from Oct 16, 2018
Merged

Add support for sqlite citext data-type #10036

merged 3 commits into from Oct 16, 2018

Conversation

@justinkalland
Copy link
Contributor

@justinkalland justinkalland commented Oct 16, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

#10024 added CITETXT for Postgres.

This isn't a real data-type in SQLite but uses COLLATE NOCASE on the TEXT field. The behavior is the same as CITEXT for Postgres with the exception of SQLite only supporting ASCII characters.

@codecov
Copy link

@codecov codecov bot commented Oct 16, 2018

Codecov Report

Merging #10036 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10036      +/-   ##
==========================================
+ Coverage    96.3%    96.3%   +<.01%     
==========================================
  Files          63       63              
  Lines        9421     9427       +6     
==========================================
+ Hits         9073     9079       +6     
  Misses        348      348
Impacted Files Coverage Δ
lib/data-types.js 95.21% <ø> (ø) ⬆️
lib/instance-validator.js 97.54% <100%> (ø) ⬆️
lib/dialects/sqlite/data-types.js 97.15% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 198cb52...f8710f3. Read the comment docs.

@sushantdhiman sushantdhiman merged commit f6d2b47 into sequelize:master Oct 16, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 96.3%)
Details
codecov/project 96.3% (+<.01%) compared to 198cb52
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 16, 2018

Thanks @justinkalland

@justinkalland justinkalland deleted the justinkalland:feature-citext-sqlite branch Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants