fix(model): create instance with many-to-many association with extra column (#10034) #10050
Conversation
| if (attr === include.association.foreignKey || attr === include.association.otherKey) { | ||
| continue; | ||
| } | ||
| values[attr] = instance[include.association.through.model.name][attr]; |
sushantdhiman
Oct 21, 2018
Contributor
Check if instance[include.association.through.model.name][attr] is defined only then we should set values[attr]
Check if instance[include.association.through.model.name][attr] is defined only then we should set values[attr]
| if (include.association.through.model.rawAttributes[attr]._autoGenerated) { | ||
| continue; | ||
| } | ||
| if (attr === include.association.foreignKey || attr === include.association.otherKey) { |
sushantdhiman
Oct 21, 2018
Contributor
Both if statements can be folded into single check?
Both if statements can be folded into single check?
Codecov Report
@@ Coverage Diff @@
## master #10050 +/- ##
==========================================
+ Coverage 96.3% 96.3% +<.01%
==========================================
Files 63 63
Lines 9410 9415 +5
==========================================
+ Hits 9062 9067 +5
Misses 348 348
Continue to review full report at Codecov.
|
|
Thanks for the review. I fixed it. |
|
Thanks, a few more changes and this should be good to go |
| expect(foo.bars[0].foobar).to.not.equal(null); | ||
| expect(foo.bars[0].foobar.baz).to.equal('baz...'); | ||
| }, () => { | ||
| expect.fail(); |
sushantdhiman
Oct 21, 2018
Contributor
expect.fail is not required promise rejection will bubble up
expect.fail is not required promise rejection will bubble up
| }).then(() => { | ||
| return Foo.findOne({ include: Bar }); | ||
| }).then(foo => { | ||
| expect(foo.name).to.equal('foo...'); |
sushantdhiman
Oct 21, 2018
Contributor
Please repeat these checks for data returned just after create as well
Please repeat these checks for data returned just after create as well
tsasaki609
Oct 21, 2018
Author
Contributor
That makes sense.
That makes sense.
|
Thanks @tsasaki609 |
|
Thank you very much @tsasaki609, excellent work! |
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
fix #10034
I tried to include extra attributes in the condition processing the scope.