Skip to content

fix(query-generator): fix bad property access#10056

Merged
sushantdhiman merged 1 commit into
sequelize:masterfrom
SimonSchick:fix/issue-9982
Oct 23, 2018
Merged

fix(query-generator): fix bad property access#10056
sushantdhiman merged 1 commit into
sequelize:masterfrom
SimonSchick:fix/issue-9982

Conversation

@SimonSchick

Copy link
Copy Markdown
Contributor

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

FIxes #9982
Also tiny cleanup 😄

Not familiar enough with the repo to find an error case but, better safe than sorry.

@SimonSchick

Copy link
Copy Markdown
Contributor Author

Now that github is done being weird.. merge? 😄

@sushantdhiman
sushantdhiman merged commit 4886b86 into sequelize:master Oct 23, 2018
@sushantdhiman

Copy link
Copy Markdown
Contributor

Thanks @SimonSchick , I was waiting for Github to go green, Yesterday I accidentally submitted 3 approved reviews on same PR because of that outage :D

@SimonSchick
SimonSchick deleted the fix/issue-9982 branch March 9, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants