Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-generator): fix bad property access #10056

Merged
merged 1 commit into from Oct 23, 2018

Conversation

@SimonSchick
Copy link
Member

@SimonSchick SimonSchick commented Oct 21, 2018

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

FIxes #9982
Also tiny cleanup 馃槃

Not familiar enough with the repo to find an error case but, better safe than sorry.

@SimonSchick
Copy link
Member Author

@SimonSchick SimonSchick commented Oct 22, 2018

Now that github is done being weird.. merge? 馃槃

@sushantdhiman sushantdhiman merged commit 4886b86 into sequelize:master Oct 23, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 23, 2018

Thanks @SimonSchick , I was waiting for Github to go green, Yesterday I accidentally submitted 3 approved reviews on same PR because of that outage :D

@SimonSchick SimonSchick deleted the SimonSchick:fix/issue-9982 branch Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants