Fix toJSON to always provide copy of data (cloneDeep)#10058
Merged
sushantdhiman merged 1 commit intosequelize:masterfrom Oct 23, 2018
jusguy:fix-model-get-json
Merged
Fix toJSON to always provide copy of data (cloneDeep)#10058sushantdhiman merged 1 commit intosequelize:masterfrom jusguy:fix-model-get-json
sushantdhiman merged 1 commit intosequelize:masterfrom
jusguy:fix-model-get-json
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10058 +/- ##
=======================================
Coverage 96.3% 96.3%
=======================================
Files 63 63
Lines 9410 9410
=======================================
Hits 9062 9062
Misses 348 348
Continue to review full report at Codecov.
|
Contributor
|
Thanks @justinkalland |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Changes
mode.toJSON()to always return a copy of the underlying data. This was a small change from lodashclone()tocloneDeep().Closes #10052