Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test for instance get with raw option #10059

Merged
merged 1 commit into from Oct 23, 2018
Merged

Fix unit test for instance get with raw option #10059

merged 1 commit into from Oct 23, 2018

Conversation

@justinkalland
Copy link
Contributor

@justinkalland justinkalland commented Oct 22, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

The test previously passed the raw option to the expect() when it was intended to be passed when building the instance. The error would cause the test to always pass.

Copy link
Contributor

@sushantdhiman sushantdhiman left a comment

Good catch

@sushantdhiman sushantdhiman merged commit a4ec7c9 into sequelize:master Oct 23, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants