fix OptimistickLockError message - #10068
Conversation
|
That's not what you expect when you use newly released inline edit button on |
6748016 to
3cbf888
Compare
Codecov Report
@@ Coverage Diff @@
## master #10068 +/- ##
=======================================
Coverage 96.3% 96.3%
=======================================
Files 63 63
Lines 9413 9413
=======================================
Hits 9065 9065
Misses 348 348
Continue to review full report at Codecov.
|
`BaseError` expects to receive `message`, but the `options` object is being passed. It leads to this: ``` SequelizeOptimisticLockError: [object Object] ``` With the fix the error looks like: ``` SequelizeOptimisticLockError: Attempting to update a stale model instance: Customers ```
3cbf888 to
c300e93
Compare
|
@sushantdhiman with all respect, I don't think that integration test is necessary here. The change is very minor and it just does the thing which was originally meant by author. So I've put additional unit test, just to be rock solid, that message it there and has correct format. Regards, |
|
@PavelPolyakov integration test is important here, I'll add that test myself soon |
BaseErrorexpects to receivemessage, but theoptionsobject is being passed.It leads to this:
With the fix the error looks like:
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change