Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): validate virtual attribute (#9947) #10085

Merged
merged 1 commit into from Oct 27, 2018

Conversation

@tsasaki609
Copy link
Contributor

@tsasaki609 tsasaki609 commented Oct 27, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

fix #9947
In the case of processing that is not bulk, we use rawAttribute, so we should do the same in this case.
https://github.com/sequelize/sequelize/blob/master/lib/model.js#L3627

@codecov
Copy link

@codecov codecov bot commented Oct 27, 2018

Codecov Report

Merging #10085 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10085   +/-   ##
=======================================
  Coverage    96.3%    96.3%           
=======================================
  Files          63       63           
  Lines        9413     9413           
=======================================
  Hits         9065     9065           
  Misses        348      348
Impacted Files Coverage Δ
lib/model.js 96.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 122bd17...7583a91. Read the comment docs.

@sushantdhiman sushantdhiman merged commit b634cd8 into sequelize:master Oct 27, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 96.3%)
Details
codecov/project 96.3% (+0%) compared to 122bd17
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 27, 2018

Thanks @tsasaki609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants