Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): correct-quote-identifiers(#9964) #10118

Merged
merged 1 commit into from Nov 4, 2018

Conversation

@tsasaki609
Copy link
Contributor

@tsasaki609 tsasaki609 commented Nov 4, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

fix #9964

@tsasaki609 tsasaki609 force-pushed the tsasaki609:fix-quote-identifiers branch from 6e47b1c to 0d72cde Nov 4, 2018
@codecov
Copy link

@codecov codecov bot commented Nov 4, 2018

Codecov Report

Merging #10118 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10118      +/-   ##
==========================================
+ Coverage   96.37%   96.37%   +<.01%     
==========================================
  Files          63       63              
  Lines        9411     9414       +3     
==========================================
+ Hits         9070     9073       +3     
  Misses        341      341
Impacted Files Coverage Δ
lib/dialects/abstract/query-generator.js 97.64% <100%> (ø) ⬆️
lib/dialects/mssql/connection-manager.js 88.6% <0%> (ø) ⬆️
lib/dialects/mssql/index.js 100% <0%> (ø) ⬆️
lib/model.js 96.8% <0%> (ø) ⬆️
lib/sequelize.js 96.62% <0%> (ø) ⬆️
lib/query-interface.js 89.8% <0%> (ø) ⬆️
...dialects/abstract/query-generator/helpers/quote.js 94.44% <0%> (ø) ⬆️
lib/dialects/mssql/data-types.js 98.13% <0%> (ø) ⬆️
lib/dialects/mssql/resource-lock.js 100% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3af0537...0d72cde. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 75f48a2 into sequelize:master Nov 4, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 96.37%)
Details
codecov/project 96.37% (+<.01%) compared to 3af0537
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Nov 4, 2018

Thanks @tsasaki609

@mbecker16
Copy link

@mbecker16 mbecker16 commented Nov 13, 2018

Thanks @tsasaki609 for fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants