Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(association): enable eager load with include all(#9928) #10173

merged 1 commit into from
Nov 17, 2018


Copy link

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in

Description of change

fix #9928
Since conditions are different for each relation, I tried using polymorphism.

Copy link

codecov bot commented Nov 17, 2018

Codecov Report

Merging #10173 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10173      +/-   ##
+ Coverage   96.36%   96.36%   +<.01%     
  Files          63       63              
  Lines        9424     9441      +17     
+ Hits         9081     9098      +17     
  Misses        343      343
Impacted Files Coverage Δ
lib/associations/belongs-to.js 100% <100%> (ø) ⬆️
lib/associations/has-many.js 97.71% <100%> (+0.06%) ⬆️
lib/associations/mixin.js 100% <100%> (ø) ⬆️
lib/associations/belongs-to-many.js 97.71% <100%> (+0.03%) ⬆️
lib/associations/has-one.js 97.24% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba5f3c...bea886d. Read the comment docs.

@sushantdhiman sushantdhiman merged commit ce9287f into sequelize:master Nov 17, 2018
Copy link

Thanks @tsasaki609 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

as: {singular, plural} not working with include: {all: true}
2 participants