feat(mariadb): implementation for MariaDB #10192
Pull Request check-list
Please make sure to review and check all of these items:
Description of change
Implementation of MariaDB.
Breaking change is the use of schemas. MySQL/MariaDB have schemas, but no "default" public schema.
Tests have been updated accordingly (defaut method that drop all schemas is replace to keep default schema that is needed for MariaDB)
@@ Coverage Diff @@ ## master #10192 +/- ## ========================================== - Coverage 96.34% 96.28% -0.07% ========================================== Files 63 68 +5 Lines 9420 9796 +376 ========================================== + Hits 9076 9432 +356 - Misses 344 364 +20
This looks almost ready @rusher , Please extend documentation so it references
I'll do some testing locally in the evening, we can hopefully merge this tomorrow
@sushantdhiman Just tell me if you think anything else is missing. I don't see any other improvement that i can do, but better bulk implementation (mariadb connector has a dedicated bath API that use a MariaDB specific protocol, but that would be another PR)