Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): enforce consistent spacing #10193

merged 1 commit into from Dec 9, 2018


Copy link

@SimonSchick SimonSchick commented Nov 22, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in

Description of change

See enabled lint rules.

The amount of changes is large but it's 100% automated changes.

Copy link

@codecov codecov bot commented Nov 27, 2018

Codecov Report

Merging #10193 into master will not change coverage.
The diff coverage is 98.96%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10193   +/-   ##
  Coverage   96.28%   96.28%           
  Files          68       68           
  Lines        9796     9796           
  Hits         9432     9432           
  Misses        364      364
Impacted Files Coverage Δ
lib/dialects/mysql/query-interface.js 100% <ø> (ø) ⬆️
lib/dialects/abstract/connection-manager.js 90.26% <100%> (ø) ⬆️
lib/model.js 96.77% <100%> (ø) ⬆️
lib/dialects/sqlite/query-interface.js 100% <100%> (ø) ⬆️
lib/dialects/postgres/query-generator.js 94.08% <100%> (ø) ⬆️
lib/associations/belongs-to.js 100% <100%> (ø) ⬆️
lib/associations/has-one.js 97.24% <100%> (ø) ⬆️
lib/sql-string.js 91.17% <100%> (ø) ⬆️
lib/dialects/mssql/query.js 92.96% <100%> (ø) ⬆️
lib/sequelize.js 96.36% <100%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c6b6e5...390563e. Read the comment docs.

@SimonSchick SimonSchick force-pushed the SimonSchick:chore/lint-spacing branch from 9348c42 to 6d248e6 Dec 8, 2018
@SimonSchick SimonSchick force-pushed the SimonSchick:chore/lint-spacing branch from 6d248e6 to 390563e Dec 8, 2018
Copy link

@sushantdhiman sushantdhiman left a comment

Thanks @SimonSchick

@sushantdhiman sushantdhiman merged commit 2874c54 into sequelize:master Dec 9, 2018
4 checks passed
4 checks passed
codecov/patch 98.96% of diff hit (target 96.28%)
codecov/project 96.28% (+0%) compared to 2c6b6e5
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
@SimonSchick SimonSchick deleted the SimonSchick:chore/lint-spacing branch Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants