Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(update): skips update when nothing to update #10248

Merged
merged 1 commit into from Dec 9, 2018
Merged

Conversation

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Dec 9, 2018

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #7101

@codecov
Copy link

@codecov codecov bot commented Dec 9, 2018

Codecov Report

Merging #10248 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10248      +/-   ##
==========================================
+ Coverage   96.28%   96.28%   +<.01%     
==========================================
  Files          68       68              
  Lines        9795     9797       +2     
==========================================
+ Hits         9431     9433       +2     
  Misses        364      364
Impacted Files Coverage Δ
lib/model.js 96.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510ff54...59e9fd5. Read the comment docs.

@sushantdhiman sushantdhiman merged commit ff1c97c into master Dec 9, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 96.28%)
Details
codecov/project 96.28% (+<.01%) compared to 510ff54
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman sushantdhiman deleted the skip-update branch Dec 9, 2018
@zupper
Copy link

@zupper zupper commented Apr 23, 2019

The same behavior is still observable in 5.7.3. Noticing the below log, where my updatedAt column is aliased to updated in the model definition's options:

2019/04/23 12:12:49 Executing (817790ac-3497-4294-b399-f85c0608cef4): UPDATE `Event` SET `updated`=? WHERE `id` = ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants