chore: cleanup #10276
Merged
chore: cleanup #10276
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10276 +/- ##
==========================================
- Coverage 96.28% 96.27% -0.01%
==========================================
Files 68 68
Lines 9797 9772 -25
==========================================
- Hits 9433 9408 -25
Misses 364 364
Continue to review full report at Codecov.
|
[foreignIdentifier]: newObj.get(targetKey) | ||
} | ||
} | ||
)) |
sushantdhiman
Dec 18, 2018
Contributor
odd indentation
odd indentation
891de8e
into
sequelize:master
4 checks passed
4 checks passed
codecov/project
Absolute coverage decreased by -<.01% but relative coverage increased by +1.79% compared to 66a4533
Details
Thanks @SimonSchick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
Fixes #10275 I think
This is another small scale cleanup PR.
Object.assign
spread
with native array spreadthis