fix(model/update): propagate paranoid to individualHooks query - #10369
Merged
Conversation
miroslavLalev
force-pushed
the
fix-update
branch
from
January 21, 2019 22:38
1696483 to
4254848
Compare
Contributor
Author
|
It seems that the AppVeyor CI test failed with something sporadic as I couldn't reproduce it. Is there any way of retriggering it? |
SimonSchick
approved these changes
Jan 22, 2019
sushantdhiman
approved these changes
Jan 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #10369 +/- ##
=======================================
Coverage 96.3% 96.3%
=======================================
Files 92 92
Lines 9813 9813
=======================================
Hits 9450 9450
Misses 363 363
Continue to review full report at Codecov.
|
Contributor
|
Thanks @miroslavLalev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
I was testing some scenarios and noticed that when:
paranoid: truesetbeforeUpdatehook defined in the model<Model>.updatemethod withindividualHooks: trueThe hook does not get called and therefore update statement is not executed. After a bit of investigation, I found the root cause - the
paranoidoption was not propagated to the select statement.As it was quite straightforward change, I decided to give it a go and created PR directly :)