Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): enabled string association #10481

Merged
merged 5 commits into from Feb 28, 2019

Conversation

3 participants
@IgorSzymanski
Copy link
Contributor

IgorSzymanski commented Feb 27, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

@SimonSchick

This comment has been minimized.

Copy link
Contributor

SimonSchick commented Feb 27, 2019

Change is sane but please add a simple test :)

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #10481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10481   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files          92       92           
  Lines        9494     9494           
=======================================
  Hits         9132     9132           
  Misses        362      362

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2429146...eab6a6a. Read the comment docs.

@IgorSzymanski

This comment has been minimized.

Copy link
Contributor Author

IgorSzymanski commented Feb 27, 2019

@SimonSchick I added some test, but I'm not sure if it's any good as I'm not that experienced in writing tests.

@sushantdhiman sushantdhiman merged commit b42bbc7 into sequelize:master Feb 28, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 2429146...eab6a6a
Details
codecov/project 96.18% remains the same compared to 2429146
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SimonSchick

This comment has been minimized.

Copy link
Contributor

SimonSchick commented Feb 28, 2019

@IgorSzymanski @sushantdhiman I should've been more specific.
There was already a test, I was talking about a test for the typings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.