feat(types): enabled string association - #10481
Merged
Merged
Conversation
Contributor
|
Change is sane but please add a simple test :) |
Codecov Report
@@ Coverage Diff @@
## master #10481 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 92 92
Lines 9494 9494
=======================================
Hits 9132 9132
Misses 362 362Continue to review full report at Codecov.
|
Contributor
Author
|
@SimonSchick I added some test, but I'm not sure if it's any good as I'm not that experienced in writing tests. |
sushantdhiman
approved these changes
Feb 28, 2019
Contributor
|
@IgorSzymanski @sushantdhiman I should've been more specific. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change