Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to tedious@6.0.0 #10494

Merged
merged 2 commits into from Mar 2, 2019
Merged

feat: update to tedious@6.0.0 #10494

merged 2 commits into from Mar 2, 2019

Conversation

sushantdhiman
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Breaking change, support tedious@6 format for dialectOptions

@codecov
Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #10494 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10494      +/-   ##
==========================================
- Coverage   96.15%   96.14%   -0.02%     
==========================================
  Files          92       92              
  Lines        9501     9501              
==========================================
- Hits         9136     9135       -1     
- Misses        365      366       +1
Impacted Files Coverage Δ
lib/model.js 96.65% <ø> (ø) ⬆️
lib/query-interface.js 91.89% <ø> (ø) ⬆️
lib/associations/mixin.js 100% <100%> (ø) ⬆️
lib/dialects/mssql/connection-manager.js 87.17% <75%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0fe772...3197cd9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant