-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(data-types): move to classes #10495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(data-types): move to classes #10495
Conversation
Arg, latest change caused a circular dependency, fixing.. |
3faab50
to
5f1e70b
Compare
@sushantdhiman I cannot repro these errors about |
Codecov Report
@@ Coverage Diff @@
## master #10495 +/- ##
==========================================
+ Coverage 96.14% 96.16% +0.01%
==========================================
Files 92 92
Lines 9501 9022 -479
==========================================
- Hits 9135 8676 -459
+ Misses 366 346 -20
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #10495 +/- ##
==========================================
+ Coverage 93.76% 96.17% +2.41%
==========================================
Files 92 92
Lines 9508 9026 -482
==========================================
- Hits 8915 8681 -234
+ Misses 593 345 -248
Continue to review full report at Codecov.
|
@sushantdhiman works now |
Please note there is a single potentially 'breaking' change: To clarify: We can change the return value, we just need to ensure it's unique for every datatype as it's used in tests. |
boop |
Hey @sushantdhiman since you are around, I'd love to get some feedback on this :) |
17df1e9
to
1b94b42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return true; | ||
}; | ||
|
||
// TODO: Create intermediate class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
2f1675a
to
2b401f4
Compare
@janmeier Not going to do the If you are interested in poking it see my branch Please approve this PR as is. |
lib/utils.js
Outdated
@@ -11,6 +11,8 @@ const operatorsArray = _.values(operators); | |||
|
|||
let inflection = require('inflection'); | |||
|
|||
exports.implicitNew = require('./utils/implicitNew'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a method classToInvokable
in these utils, which is same as implicitNew
. Either use that old method or get rid of classToInvokable
so we only use one common method
There are some unrelated changes in this PR, please rebase with master |
2b401f4
to
e56256b
Compare
1) The design does not make sense, all parameters are constants and are independent of the execution parameters. 2) lack of support for packers (webpack, browserify) 3) unusable design in es6 https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-dynamic-require.md
sequelize#10495 - fix bug of require dialectMap
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
Remaining:
Proxy
which isn't necessarily very performant but should have no real impact on performance.inferNew
be exposed (as in the new docs)?