Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): don't prepare options & sql for every retry #10498

merged 3 commits into from
Mar 3, 2019


Copy link

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in

Description of change

Fixes #10453 , Now options and sql are only prepared once, retry logic only deals with obtaining connection and querying SQL prepared in first step.

Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #10498 into master will decrease coverage by <.01%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10498      +/-   ##
- Coverage   96.14%   96.14%   -0.01%     
  Files          92       92              
  Lines        9501     9500       -1     
- Hits         9135     9134       -1     
  Misses        366      366
Impacted Files Coverage Δ
lib/sequelize.js 96.28% <97.14%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c0d78...9892d9b. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 10c34e3 into master Mar 3, 2019
@sushantdhiman sushantdhiman deleted the fix-retry-bind branch March 3, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant