fix(types): allow specifying additional options for db.query and add missing retry#10512
Merged
sushantdhiman merged 1 commit intosequelize:masterfrom Mar 8, 2019
Merged
Conversation
Contributor
|
Lines 482 to 488 in 45648dd Both |
Contributor
|
Let me know if this is ready |
Contributor
Author
|
@sushantdhiman what exactly is the return type if, for example |
Contributor
|
|
Contributor
Author
|
So does |
Contributor
|
Setting model has no effect on type, if type is already set |
Contributor
Author
|
So, in typings we should probably not support setting both at the same time then as it's pointless and probably an error. In this case this PR is complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
See title
fixes #10506
@sushantdhiman can you clarify if you can specify BOTH the query
typeANDmodel?It seems that when model is specified it implicitly uses
SELECTbut what iftypeis specified?