Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(association): use empty select for hasAssociation #10529

Merged
merged 2 commits into from
Mar 9, 2019

Conversation

sushantdhiman
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #10514

@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #10529 into master will increase coverage by 2.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10529      +/-   ##
==========================================
+ Coverage   93.77%   96.17%   +2.39%     
==========================================
  Files          92       92              
  Lines        9508     9508              
==========================================
+ Hits         8916     9144     +228     
+ Misses        592      364     -228
Impacted Files Coverage Δ
lib/associations/has-many.js 97.59% <ø> (ø) ⬆️
lib/associations/belongs-to-many.js 97.93% <ø> (+0.34%) ⬆️
lib/dialects/abstract/query-generator.js 97.57% <0%> (+0.26%) ⬆️
lib/dialects/abstract/query.js 90.45% <0%> (+0.35%) ⬆️
lib/sequelize.js 96.28% <0%> (+3.09%) ⬆️
lib/dialects/mysql/query-generator.js 97.88% <0%> (+11.86%) ⬆️
lib/dialects/mysql/data-types.js 96.07% <0%> (+46.07%) ⬆️
lib/dialects/mysql/connection-manager.js 96.36% <0%> (+67.27%) ⬆️
lib/dialects/mysql/query.js 98.44% <0%> (+78.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ccbb1e...f831019. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 1b4a7bf into master Mar 9, 2019
@sushantdhiman sushantdhiman deleted the improve-has-association branch March 9, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

has[Association]() makes a complete INNER JOIN SELECT - should be lightweight confirmation, proof and solution
1 participant