Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dialect): remove broken link #11193

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@morugu
Copy link
Contributor

commented Jul 15, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

I removed broken link for old options page.

@codecov

This comment has been minimized.

Copy link

commented Jul 15, 2019

Codecov Report

Merging #11193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11193   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files          94       94           
  Lines        9023     9023           
=======================================
  Hits         8693     8693           
  Misses        330      330

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0b137...51b19a3. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 715a82f into sequelize:master Jul 18, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 6e0b137...51b19a3
Details
codecov/project 96.34% remains the same compared to 6e0b137
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sushantdhiman

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

🎉 This PR is included in version 5.10.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sushantdhiman

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

🎉 This PR is included in version 7.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.