fix(typings): add missing nested to Includeable

[vanthome]

Typings were missing previously.

Description of change

Add nested to typings Includeable.

[codecov]

Codecov Report

Merging #11354 into master will decrease coverage by 8.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11354      +/-   ##
==========================================
- Coverage   96.26%   87.55%   -8.72%     
==========================================
  Files          94       91       -3     
  Lines        9190     8847     -343     
==========================================
- Hits         8847     7746    -1101     
- Misses        343     1101     +758

Impacted Files	Coverage Δ
lib/dialects/postgres/query-generator.js	1.79% <0%> (-92.59%)	⬇️
lib/dialects/postgres/range.js	7.69% <0%> (-92.31%)	⬇️
lib/dialects/postgres/query-interface.js	7.57% <0%> (-90.91%)	⬇️
lib/errors/database/exclusion-constraint-error.js	18.18% <0%> (-81.82%)	⬇️
lib/dialects/postgres/data-types.js	19.62% <0%> (-76.64%)	⬇️
lib/dialects/postgres/hstore.js	42.85% <0%> (-57.15%)	⬇️
lib/deferrable.js	14.28% <0%> (-57.15%)	⬇️
...dialects/abstract/query-generator/helpers/quote.js	73.33% <0%> (-26.67%)	⬇️
lib/query-interface.js	82.43% <0%> (-9.76%)	⬇️
lib/data-types.js	86.5% <0%> (-4.85%)	⬇️
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77c553...e90249e. Read the comment docs.

[papb]

LGTM

[sushantdhiman]

This needs a typing test similar to

sequelize/types/test/include.ts

Line 27 in 5860ef5

MyModel.findAll({

[papb]

@vanthome it seems you pushed a new commit by accident, am I right?

[vanthome]

OMG, I did not know that pushes are still synchronized here because I did not crate another PR. I guess when we close this PR this will no longer be the case, or?
Btw. I will prepare this as a fresh PR hopefully soon.

[papb]

Whenever you push to the missing_typing branch, this PR will be updated (unless it was already merged, of course). I am not sure what would happen if the PR is closed (not merged), but I'd guess it would still be updated, except that probably the automatic checks would not run...

If you want to work on multiple PRs at the same time you just have to create one branch for each one and pay attention where you are commiting :)

[papb]

This needs a typing test similar to

sequelize/types/test/include.ts

Line 27 in 5860ef5

MyModel.findAll({

By the way can you address this comment so we can merge this PR?

[vanthome]

Ok, I was accidental in a branch. I reverted and rebased. Btw. why is this not merged yet? Is there something missing?

[sushantdhiman]

#11354 (comment)

[papb]

I think you pushed by mistake again 😬

By the way please address the comment so we can merge this

[papb]

@vanthome If you need help to create the test let me know

[vanthome]

NP, added the test, now please merge it.

[vanthome]

Just one question. I'm working on another PR but now with the 6.0 master the existing PG tests are failing for me:

  1) [POSTGRES] Model
       schemas
         regressions
           should be able to sync model with schema:
     TypeError: s.replace is not a function
      at Object.removeTicks (lib/utils.js:354:12)
      at Object.quoteIdentifier (lib/dialects/abstract/query-generator/helpers/quote.js:50:35)
      at PostgresQueryGenerator.quoteIdentifier (lib/dialects/abstract/query-generator.js:859:24)
      at PostgresQueryGenerator.quoteTable (lib/dialects/abstract/query-generator.js:906:23)
      at PostgresQueryGenerator.addIndexQuery (lib/dialects/abstract/query-generator.js:543:24)
      at QueryInterface.addIndex (lib/query-interface.js:658:37)
      at /P/BMS-LSA/sequelize/lib/model.js:1358:67
  From previous event:
      at /P/BMS-LSA/sequelize/lib/model.js:1358:24
  From previous event:
      at Function.sync (lib/model.js:1345:8)
      at Context.<anonymous> (test/integration/model/schema.test.js:543:23)
      at processImmediate (internal/timers.js:439:21)

Can you confirm that they are not functioning right now?

[papb]

Great!

[papb]

About the tests you mentioned, that's odd, latest commit on master has a green checkmark... I suggest you proceed with your PR, if you think the error is unrelated just ignore it for now, we shall look into it once you open the PR :)