fix(associations): allow binary key for belongs-to-many#11578
Merged
sushantdhiman merged 1 commit intosequelize:masterfrom Oct 19, 2019
Merged
fix(associations): allow binary key for belongs-to-many#11578sushantdhiman merged 1 commit intosequelize:masterfrom
sushantdhiman merged 1 commit intosequelize:masterfrom
Conversation
Contributor
Author
|
Oops CI failed...
MySQL requires a length specification for the BLOB data type. |
129460c to
1d1d552
Compare
Codecov Report
@@ Coverage Diff @@
## master #11578 +/- ##
==========================================
- Coverage 96.27% 95.87% -0.41%
==========================================
Files 94 91 -3
Lines 9186 8984 -202
==========================================
- Hits 8844 8613 -231
- Misses 342 371 +29
Continue to review full report at Codecov.
|
1d1d552 to
73b9363
Compare
sushantdhiman
approved these changes
Oct 19, 2019
Contributor
|
@tsasaki609 merged to master which is currently pointing to |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
fix #11545