Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(associations): allow binary key for belongs-to-many #11578

Merged

Conversation

@tsasaki609
Copy link
Contributor

@tsasaki609 tsasaki609 commented Oct 19, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

fix #11545

@tsasaki609
Copy link
Contributor Author

@tsasaki609 tsasaki609 commented Oct 19, 2019

Oops CI failed...

SequelizeDatabaseError: BLOB/TEXT column 'id' used in key specification without a key length

MySQL requires a length specification for the BLOB data type.
I'll try to fix.

@tsasaki609 tsasaki609 force-pushed the fix-binary-key-association branch from 129460c to 1d1d552 Oct 19, 2019
@codecov
Copy link

@codecov codecov bot commented Oct 19, 2019

Codecov Report

Merging #11578 into master will decrease coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11578      +/-   ##
==========================================
- Coverage   96.27%   95.87%   -0.41%     
==========================================
  Files          94       91       -3     
  Lines        9186     8984     -202     
==========================================
- Hits         8844     8613     -231     
- Misses        342      371      +29
Impacted Files Coverage Δ
lib/associations/belongs-to-many.js 98.07% <100%> (ø) ⬆️
lib/dialects/mariadb/query-generator.js 14.28% <0%> (-85.72%) ⬇️
lib/dialects/mariadb/data-types.js 50.98% <0%> (-49.02%) ⬇️
lib/query-interface.js 90.73% <0%> (-1.47%) ⬇️
lib/sequelize.js 95.32% <0%> (-0.63%) ⬇️
lib/dialects/mariadb/index.js
lib/dialects/mariadb/connection-manager.js
lib/dialects/mariadb/query.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9baa2...73b9363. Read the comment docs.

@tsasaki609 tsasaki609 force-pushed the fix-binary-key-association branch from 1d1d552 to 73b9363 Oct 19, 2019
@sushantdhiman sushantdhiman merged commit 409a938 into sequelize:master Oct 19, 2019
4 checks passed
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Oct 19, 2019

@tsasaki609 merged to master which is currently pointing to v6-beta, if you need a v5 release please submit a new PR for v5 branch as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants