fix: fix type of methods in query-interface #11582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR, can you please add more tests? |
SimonSchick
approved these changes
Oct 19, 2019
types/lib/query-interface.d.ts
Outdated
| @@ -120,6 +120,15 @@ export interface QueryInterfaceDropAllTablesOptions extends QueryInterfaceOption | |||
| skip?: string[]; | |||
| } | |||
|
|
|||
| export interface TablenameWithSchema { | |||
There was a problem hiding this comment.
Should probably be TableName.
There was a problem hiding this comment.
Do you mean it should be TableName or TableNameWithSchema?
There was a problem hiding this comment.
He probably means TableNameWithSchema
Codecov Report
@@ Coverage Diff @@
## master #11582 +/- ##
=========================================
- Coverage 96.26% 92.47% -3.8%
=========================================
Files 94 91 -3
Lines 9190 8903 -287
=========================================
- Hits 8847 8233 -614
- Misses 343 670 +327
Continue to review full report at Codecov.
|
2kindsofcs
force-pushed
the
fix_type_of_query_interface
branch
from
5e3c533
to
e72dc36
Compare
|
@papb hi. I added some tests. I was wondering if you think there should be more tests. |
papb
requested changes
Oct 21, 2019
types/lib/query-interface.d.ts
Outdated
| as?: string; | ||
| name?: string; | ||
| } | ||
| export type Tablename = string | TablenameWithSchema; |
There was a problem hiding this comment.
Suggested change
| export type Tablename = string | TablenameWithSchema; | |
| export type TableName = string | TableNameWithSchema; |
|
@2kindsofcs Thanks, I think those tests are enough now. |
papb
added
status: awaiting response
papb
approved these changes
Oct 22, 2019
papb
added
status: awaiting maintainer
and removed
status: awaiting response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?(npm run test-typings, actaully)
Description of change
as described in #11027, many of the QueryInterface methods accept something like
string | { tableName: string, schema: string }as the first argument. however, they are accepting tableName with string type only. So I added interface and type so that they could get arguments other than string.