Skip to content

Update associations.md#11592

Merged
papb merged 1 commit into
sequelize:masterfrom
Ivaylo-Kirov:patch-1
Oct 23, 2019
Merged

Update associations.md#11592
papb merged 1 commit into
sequelize:masterfrom
Ivaylo-Kirov:patch-1

Conversation

@Ivaylo-Kirov

Copy link
Copy Markdown
Contributor

Fixed a quick typo.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixed a quick typo.
@codecov

codecov Bot commented Oct 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #11592 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11592   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files          94       94           
  Lines        9190     9190           
=======================================
  Hits         8847     8847           
  Misses        343      343

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edac3e9...ccf2dac. Read the comment docs.

@papb papb added status: awaiting maintainer docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. labels Oct 21, 2019

@papb papb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! LGTM

@sushantdhiman

Copy link
Copy Markdown
Contributor

@papb You can merge most documentation updates :) Tag for review if there are big changes that might need extra review.

@papb papb merged commit 843375f into sequelize:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants