Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #11592

merged 1 commit into from Oct 23, 2019

Update #11592

merged 1 commit into from Oct 23, 2019


Copy link

@Ivaylo-Kirov Ivaylo-Kirov commented Oct 21, 2019

Fixed a quick typo.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in

Description of change

Fixed a quick typo.
Copy link

@codecov codecov bot commented Oct 21, 2019

Codecov Report

Merging #11592 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11592   +/-   ##
  Coverage   96.26%   96.26%           
  Files          94       94           
  Lines        9190     9190           
  Hits         8847     8847           
  Misses        343      343

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edac3e9...ccf2dac. Read the comment docs.

@papb papb added status: awaiting maintainer type: docs labels Oct 21, 2019
papb approved these changes Oct 21, 2019
Copy link

@papb papb left a comment

Thanks!! LGTM

Copy link

@sushantdhiman sushantdhiman commented Oct 23, 2019

@papb You can merge most documentation updates :) Tag for review if there are big changes that might need extra review.

@papb papb merged commit 843375f into sequelize:master Oct 23, 2019
4 checks passed
@papb papb removed the status: awaiting maintainer label Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
type: docs
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants