Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(hook): add info about belongsToMany #11601

Merged
merged 3 commits into from Oct 24, 2019

Conversation

BigsonLvrocha
Copy link
Contributor

@BigsonLvrocha BigsonLvrocha commented Oct 23, 2019

Description of change

Close #11600
Add information that beforeBulkCreate/afterBulkCreate hooks will run

Add information that beforeBulkCreate/afterBulkCreate hooks will run
@papb
Copy link
Member

@papb papb commented Oct 23, 2019

Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

I have a question, posted in your issue :)

@papb papb added status: awaiting response type: docs labels Oct 23, 2019
@codecov
Copy link

@codecov codecov bot commented Oct 23, 2019

Codecov Report

Merging #11601 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11601      +/-   ##
==========================================
+ Coverage   96.24%   96.26%   +0.02%     
==========================================
  Files          94       94              
  Lines        9190     9190              
==========================================
+ Hits         8845     8847       +2     
+ Misses        345      343       -2
Impacted Files Coverage Δ
lib/dialects/postgres/connection-manager.js 95.77% <0%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 843375f...9a61e9c. Read the comment docs.

papb
papb approved these changes Oct 23, 2019
Copy link
Member

@papb papb left a comment

Thanks!

@papb
Copy link
Member

@papb papb commented Oct 23, 2019

Please make the branch up-to-date with master (rebase or merge master into it)

@papb papb merged commit 7ffa3d4 into sequelize:master Oct 24, 2019
4 checks passed
@BigsonLvrocha BigsonLvrocha deleted the update-hook-do-belongs-to-many branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting response type: docs
Projects
None yet
2 participants