fix: escape dollarsign in sequelize.fn related to issue 11533#11606
fix: escape dollarsign in sequelize.fn related to issue 11533#11606sushantdhiman merged 4 commits intosequelize:masterfrom
Conversation
|
Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future! Tests are failing though, please take a look :) Also your branch was outdated, I just brought it up to date for you (don't worry about this): Let me know if you need help. Thanks!! |
Codecov Report
@@ Coverage Diff @@
## master #11606 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 94 94
Lines 9190 9190
=======================================
Hits 8847 8847
Misses 343 343
Continue to review full report at Codecov.
|
papb
left a comment
There was a problem hiding this comment.
Great, I like your tests, and tests are passing, so LGTM!
|
I'm having this problem: const theCode = '10$off';
PromoCodes.findAll({
where: {
code: sequelize.where(sequelize.fn('lower', sequelize.col('code')), sequelize.fn('lower', theCode))
}
});This never finds it because it does |

Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
#11533