-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: escape dollarsign in sequelize.fn related to issue 11533 #11606
Conversation
Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future! Tests are failing though, please take a look :) Also your branch was outdated, I just brought it up to date for you (don't worry about this): Let me know if you need help. Thanks!! |
Codecov Report
@@ Coverage Diff @@
## master #11606 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 94 94
Lines 9190 9190
=======================================
Hits 8847 8847
Misses 343 343
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I like your tests, and tests are passing, so LGTM!
I'm having this problem: const theCode = '10$off';
PromoCodes.findAll({
where: {
code: sequelize.where(sequelize.fn('lower', sequelize.col('code')), sequelize.fn('lower', theCode))
}
}); This never finds it because it does |
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
#11533